Static Website Pre-Rendered at build #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ced7354)
(cherry picked from commit 80c8226)
(cherry picked from commit eff4589)
(cherry picked from commit bb12693)
(cherry picked from commit 7a1afec)
(cherry picked from commit f140eba)
(cherry picked from commit 125e5b9)
(cherry picked from commit 806bd01)
(cherry picked from commit 97f8fe3)
(cherry picked from commit 3033cb5)
(cherry picked from commit d7a976f)
(cherry picked from commit f88f4ab)
(cherry picked from commit 0825950)
(cherry picked from commit 42f07aa)
base href was needed on LordKa0S/master for github pages host, unnecessary on qbittorrent/master
|
@Chocobo1 have you seen this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live
Why
This site makes a pretty good argument for static sites. Further, costs are reduced with no server-side execution. The webpack build ensures that only the necessary assets are exposed (example exposed asset on the current site).
The Good
Site feels much snappier, and is confirmed by PageSpeed Insights and web.dev Measure. Below are the results comparing the news page, which has the most content:
Mobile
Current
Proposed
Desktop
Current
Proposed
The Bad
So far, I've found only one issue: on both desktop and mobile, the menu section is not exactly the same as the current site.On desktop, the menu items are slightly closer together.On mobile, they don't flex into multiline when width is decreased.I've tried comparing diffs of the stylesheet and the markup after they've loaded into the browser, and they seem to be exactly the same. If someone finds out what's changed, feel free to let me know in the comments.Update: Fixed in 864a426
Disclaimer
I know that this is an attempt at solving a non-issue. I stumbled across this repo browsing for a BitTorrent client for my device, and found the complexity to be just enough for me to have a go at what I believe to be improvements. That said, I completely understand if the contributors to this project are not comfortable with the complete architecture change I'm proposing. I'd appreciate constructive review of my changes, even if they're not ultimately merged.