Fix some file renaming woes (probably) #20128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you look at https://github.com/qbittorrent/qBittorrent/issues?q=is%3Aopen+is%3Aissue+label%3A%22Data+loss%22 and see which tickets this PR addresses ? |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
Not stale, I just don’t have the bandwidth to hunt through issues in an unfamiliar repo. |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
Not stale
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hullo, new contributer, wanted to avoid others losing data the way I just did!
I added a few new checks that, to my knowlege, will prevent users from renaming files on top of files that exist. While this can be useful for reseeding, it causes instant data loss if qbittorrent has downloaded any part of the existing file.
I also do some cleanup on messages and exists() function.
Reject the PR if you'd prefer to move the functionality to a different place, but I had the itch to hack something up to fix this, and I couldn't resist.
Probably closes a few issues, but I wasn't sure which, and I should get back to final projects.