Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS: Add Vietnamese translation #20259

Closed
wants to merge 1 commit into from
Closed

Conversation

ziyndev
Copy link

@ziyndev ziyndev commented Jan 11, 2024

I added a translation for the NSIS installer for Vietnamese

@thalieht thalieht added Translations Related to i18n or Transifex NSIS NSIS installer related labels Jan 12, 2024
@glassez glassez changed the title Added Vietnamese translation for the NSIS installer NSIS: Add Vietnamese translation Jan 13, 2024
@luzpaz
Copy link
Contributor

luzpaz commented Feb 20, 2024

LGTM, i don't speak the language but roughly it looks harmless to merge

@luzpaz
Copy link
Contributor

luzpaz commented Feb 26, 2024

What's blocking merge ?

@ziyndev
Copy link
Author

ziyndev commented Feb 27, 2024

What's blocking merge ?

image

@sledgehammer999
Copy link
Member

This is blocked because Vietnamese isn't one of the builtin languages of NSIS.
It is a technical limitation of integrating new languages. Or more precisely, the lack of documentation on how to do that.
See my explanation in the following comment: #18935 (comment)

@sledgehammer999
Copy link
Member

Take notice of PR #20501

Copy link

github-actions bot commented May 3, 2024

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

@github-actions github-actions bot added the Stale label May 3, 2024
Copy link

This PR was closed because it has been stalled for some time with no activity.

@github-actions github-actions bot closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSIS NSIS installer related Stale Translations Related to i18n or Transifex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants