Add four new icons to the View menu #20406
Conversation
|
LGTM, untested |
| m_ui->actionRSSReader->setIcon(UIThemeManager::instance()->getIcon(u"rss"_s)); | ||
| m_ui->actionShowFiltersSidebar->setIcon(UIThemeManager::instance()->getIcon(u"view-sidetree"_s)); | ||
| m_ui->actionSpeedInTitleBar->setIcon(UIThemeManager::instance()->getIcon(u"speedometer"_s)); | ||
| m_ui->actionSearchWidget->setIcon(UIThemeManager::instance()->getIcon(u"search"_s)); |
There was a problem hiding this comment.
IIRC, there are no such icons in qBittorrent sources (except "speedometer" one).
There was a problem hiding this comment.
Ok, I've just tested this on windows & here are the results:
Before This PR:
checkboxes/icons are all aligned vertically
With this PR:
Only the speedometer is added & it takes the place of the checkbox!
speedometer - clicked/enabled
There was a problem hiding this comment.
@buckmelanoma why are the results different than yours ?
There was a problem hiding this comment.
@buckmelanoma why are the results different than yours ?
Because they use icons from Linux theme.
|
From the screens provided by @xavier2k6 it is clear that the checkboxes are replaced by the icons (when available by the icon theme). IMO, a checkbox provides a much better indication to the user that the item is toggleable and the state of the toggle. |
I wouldn't approve it anyway. #20406 (comment) |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
This PR was closed because it has been stalled for some time with no activity. |
This pull request adds four new icons to actions in the View menu that are currently missing icons:
Before:
After:
