Show download progress for folders with zero byte size as 100 instead of 0 #20567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the download progress calculation for folders with zero size. Previously, the progress would be Zero. Now, folders with zero size show 100% progress. Closes qbittorrent#19354
|
Issue doesn't occur for files since the file progress is set to 100 if size is 0 Refer: qBittorrent/src/base/bittorrent/torrentimpl.cpp Line 1307 in d7aaf80 |
glassez
reviewed
Mar 19, 2024
| @@ -147,10 +147,19 @@ void TorrentContentModelFolder::recalculateProgress() | |||
| tRemaining += child->remaining(); | |||
| } | |||
|
|
|||
| if (!isRootItem() && (tSize > 0)) | |||
| if (!isRootItem()) | |||
There was a problem hiding this comment.
I believe it is enough to initialize m_progress as 1.0 in TorrentContentModelFolder constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the download progress calculation for folders with zero size. Previously, the progress would be zero. Now, folders with zero size show 100% progress.
Closes #19354.
Currently:
Fix:
