WebUI: Improve accuracy of trackers list #20601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piccirello
force-pushed
the
webui-trackers-list
branch
from
b783aec
to
e93d69f
Compare
Chocobo1
reviewed
Mar 24, 2024
This PR fixes various accounting issues with the trackers list. Removing a torrent would not update the trackers list, nor would removing a tracker from a torrent. And removing a tracker with a shared host but unique url (e.g. example.com/1 and example.com/2) would erroneously remove the tracker's host from the list. Closes qbittorrent#20054.
Piccirello
force-pushed
the
webui-trackers-list
branch
from
e93d69f
to
0bf3ce6
Compare
Chocobo1
approved these changes
Mar 25, 2024
thalieht
approved these changes
Mar 25, 2024
|
@Piccirello |
|
I'd be happy to backport it if we plan to ship another 4.6 release. |
@Piccirello |
|
There are some intermediate changes introduced in 9bfb447, so a cherry-pick won't be a clean merge. I think it's easiest to just wait for the release of v5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various accounting issues with the trackers list. Removing a torrent would not update the trackers list, nor would removing a tracker from a torrent. And removing a tracker with a shared host but unique url (e.g. example.com/1 and example.com/2) would erroneously remove the tracker's host from the list, despite trackers with that host still remaining.
Closes #20054, closes #20053.