Using Command + Backspace as the shortcut to delete torrents on macOS #20668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobo1
reviewed
Apr 7, 2024
| @@ -857,6 +857,7 @@ void MainWindow::createKeyboardShortcuts() | |||
| m_ui->actionExit->setShortcut(Qt::CTRL | Qt::Key_Q); | |||
| #ifdef Q_OS_MACOS | |||
| m_ui->actionCloseWindow->setShortcut(QKeySequence::Close); | |||
| m_ui->actionDelete->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_Backspace)); | |||
There was a problem hiding this comment.
Remove redundant cast:
Suggested change
| m_ui->actionDelete->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_Backspace)); | |
| m_ui->actionDelete->setShortcut(Qt::CTRL | Qt::Key_Backspace); |
Also shouldn't you use QAction::setShortcuts? otherwise you'll override line 854.
There was a problem hiding this comment.
Could this code style be approved? Or should it be called separately?
m_ui->actionDelete->setShortcut(
#ifdef Q_OS_MACOS
Qt::CTRL | Qt::Key_Backspace
#else
QKeySequence::Delete
#endif
);There was a problem hiding this comment.
Could this code style be approved?
I wouldn't use it if there are other ways. Besides that code is still overriding QKeySequence::Delete. Qt::CTRL | Qt::Key_Backspace should be additional to QKeySequence::Delete. They are not mutually exclusive.
Would the following work? Are you able to confirm it?
Suggested change
| m_ui->actionDelete->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_Backspace)); | |
| m_ui->actionDelete->setShortcuts(Qt::CTRL | Qt::Key_Backspace); |
There was a problem hiding this comment.
setShortcuts(Qt::CTRL | Qt::Key_Backspace) works. Following your suggestion, I pushed a new commit.
glassez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS usually uses the Command key plus another key as shortcuts, similar to qBittorrent's other shortcuts.
Closes #20187.