WebAPI: Provide "isPrivate" flag via "torrents/info" endpoint #20686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManiMatter
changed the title
ManiMatter
changed the title
glassez
changed the title
glassez
changed the title
glassez
approved these changes
Apr 29, 2024
|
Thank you for the review and approval, @glassez I was just thinking: the /info API supports parameters to retrieve torrents matching the filter conditions (eg by status, hash list, category, tag, etc) Would it make sense to also add the filtration method „isPrivate“ (to retrieve either only private or non-private torrents)? Personally I‘d use this. wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the "isPrivate" flag is only present on the "properties"-API:
/api/v2/torrents/properties
With this PR, I'd like to add it to the "info" -API:
/api/v2/torrents/info
Advantage: This way it can be retrieved for all torrents in one go (rather than having to query the properties-API for each hash 1 by 1)
Disclaimer: I tried to the best of my abilities to read the code and amend it (which I believe is a super simple change).
I was not able (due to my lack of skill) to build qBit with my change and test it.
Thank you very much for your review.