New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buttons to select/check files based on filter #20698
base: master
Are you sure you want to change the base?
Conversation
IMO there is no need for the extra buttons. Select all/none should apply to whatever has passed the filter. |
@xavier2k6 |
Not that I'm aware of. |
I just had a quick look:
|
The current implementation would be more versatile: |
The select matches button works strangely, as if it doesn't select anything. When trying to set a different priority to the selected files, it applies only to the one I clicked on myself. |
Ah, one thing that I found confusing writing this change The select and deselect buttons seem to act as expected on mouse selected items. One solution would be to change the other instances of Anyone with a good understanding of QTreeViews and an opinion? |
This makes it easy to mark a subset of a deep directory structure of files for download.
If I want to download all the qBittorrent source code apart from the header files:
*.h
and select all that matchThis needs some UX work to avoid confusion:
Select All/None mark files for download.
"Select Selected" does the same for the selected items.
"Check all" would imply verifying (rechecking) the downloads.
Maybe "Highlight Matched" and "Select Highlighted" would be better.
Maybe "Select All" should become "Mark All".