WebUI: Restore previously used tab on load #20705
Conversation
This simplifies development as developers can now directly set breakpoints in the browser on search code.
The log panel may be displayed before its JS has loaded, which results in an error. This prevents the error by delaying initialization until the necessary scripts are loaded.
| console.error(`Unexpected 'selected_tab' value: ${previouslyUsedTab}`) | ||
| $('transfersTabLink').click(); |
There was a problem hiding this comment.
| console.error(`Unexpected 'selected_tab' value: ${previouslyUsedTab}`) | |
| $('transfersTabLink').click(); | |
| console.error(`Unexpected 'selected_tab' value: ${previouslyUsedTab}`); | |
| $('transfersTabLink').click(); | |
| break; |
Would be nice to have a break for the last case.
There was a problem hiding this comment.
I did a quick search before pushing this change and MDN's examples don't include a break in the default case. It makes sense since there's nothing further that can run.
There was a problem hiding this comment.
It is for 'defensive' coding that it will prevent someone adding another case below and forget to add a break up here.
https://softwareengineering.stackexchange.com/questions/201777/break-on-default-case-in-switch
There was a problem hiding this comment.
It wouldn't make any sense to add a case below the default. This seems like a stylistic choice that is low impact enough to not warrant spending more time on.
There was a problem hiding this comment.
It wouldn't make any sense to add a case below the default.
You wouldn't believe the kind of stupid mistakes that happens when code changes, especially by naive coders (and even by veteran coders).
This seems like a stylistic choice that is low impact enough to not warrant spending more time on.
I agree about the 'not warrant spending more time' part but not about the 'low impact' part.
Also I would like to reiterate that I'll not be responsible for any breakage of WebUI and I only help review in best effort. So please don't ever ping me about it when it happens. I've done my best (concerning long-term maintainability) but they wouldn't even move their finger for a trivial change. I'll just approve it so everyone is happy.
This logic bug prevented the double click handler from being readded to rows once the search completed.
This PR restores the users previously used tab (Transfer, Search, RSS, etc.) when the Web UI is reloaded.
Screen.Recording.2024-04-14.at.23.33.19.mov