Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSIS: Adding Bengali and Hindi languages #20713

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

NSIS: Adding Bengali and Hindi languages #20713

wants to merge 2 commits into from

Conversation

Javed-ahmed-shanto
Copy link

Adding Bengali Translating strings used in NSIS installer
adding Bengali language strings

@luzpaz luzpaz added the NSIS NSIS installer related label Apr 16, 2024
@Javed-ahmed-shanto
Copy link
Author

Added Hindi Language file (hindi.nsh)

@luzpaz luzpaz changed the title Adding the language of Bengali (bengali.nsh file) in installation … NSIS: Adding Bengali and Hindi languages Apr 18, 2024
@Javed-ahmed-shanto
Copy link
Author

Any update on the approval?

@glassez
Copy link
Member

glassez commented Apr 28, 2024

Any update on the approval?

Did you test it?
IIRC, it won't work if you just add translation for some language, unless NSIS itself provides support for that language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sledgehammer999 sledgehammer999 Awaiting requested review from sledgehammer999

At least 1 approving review is required to merge this pull request.

Assignees

@sledgehammer999 sledgehammer999

Labels
NSIS NSIS installer related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Javed-ahmed-shanto @glassez @sledgehammer999 @luzpaz