New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI: migrate ESLint rules #20727
WebUI: migrate ESLint rules #20727
Conversation
@Chocobo1 A few questions, if you don't mind. What about using
I noticed the Can qBittorrent/src/webui/www/package.json Lines 14 to 15 in d3315f7
|
Our webui targets browsers released from a year ago so
Specifying the latest spec would require website visitors use a very up-to-date browser and would (possibly) block non-trivial portion of viewers, I wouldn't recommend that.
It seems v9.x is stable now. I plan to migrate over but the config file would also need migrated. |
👍
Ahh...I thought it was only just related to the CI. I think it would be ok though to bump pinned dependency of |
You can use this calculator to check which version will be picked: https://semver.npmjs.com/ IMO it would be better if it was specified |
@Chocobo1 Thanks for the explanation & link, the change is trivial - so will leave it to you if you want to change it or not, there's a |
PR updated, resolved merge conflicts. |
https://eslint.style/guide/migration