Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pause/resume entire BitTorrent session #20757

Merged
merged 5 commits into from May 3, 2024

Conversation

glassez
Copy link
Member

@glassez glassez commented Apr 25, 2024

  • Replaces current unsafe Start all and Stop all actions with Pause session and Resume session (paused session preserves started/stopped states of torrents when resumed).
  • Adds an option to start session in paused state.

Closes #18993.

001

003

004

002

thalieht
thalieht previously approved these changes Apr 25, 2024
@thalieht
Copy link
Contributor

One minor issue which i'm not even sure that it's a bug: Disabling the queue doesn't update the state of queued torrents while session is paused.

@glassez
Copy link
Member Author

glassez commented Apr 26, 2024

Disabling the queue doesn't update the state of queued torrents while session is paused.

I suppose you mean changing "queued" to "seeding" or "downloading".
I tried to fix it, but I don't know if I succeeded, since I haven't had the opportunity to test it yet.
Should be fixed now.

@glassez glassez requested a review from a team April 26, 2024 12:13
@glassez glassez added this to the 5.0 milestone Apr 26, 2024
@glassez glassez merged commit 8ef7d3e into qbittorrent:master May 3, 2024
9 of 14 checks passed
@glassez glassez deleted the session-pause branch May 3, 2024 06:02
@glassez glassez changed the title Add ability to pause/resume entire session Add ability to pause/resume entire BitTorrent session May 3, 2024
@Roardom
Copy link

Roardom commented May 3, 2024

Am I understanding correctly that, when a user pauses their session, that private trackers will receive no announces saying that their client has stopped their torrents?

This would prevent me from being able to delete their IP from the database, or being able to configure a suitable time out for how long I should keep their data after expecting users to announce again. I also can't keep reasonable statistics.

Or am I misunderstanding?

@glassez
Copy link
Member Author

glassez commented May 3, 2024

Or am I misunderstanding?

Yes.
It works as if you stopped all your torrents. The only difference is that it preserves individual torrent states, so when you resume the session, previously stopped torrents will remain stopped.

@Roardom
Copy link

Roardom commented May 3, 2024

Or am I misunderstanding?

Yes. It works as if you stopped all your torrents. The only difference is that it preserves individual torrent states, so when you resume the session, previously stopped torrents will remain stopped.

Perfect, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to pause all torrents when quitting qBT
4 participants