Changeable fonts in torrent list, torrent properties and execution log. #6196
Conversation
|
@Zalewa There are errors in the GUI-less builds, please take a look. |
|
Thanks for pinging me, @evsh, I missed it. I rebased onto the newest master and noticed that new icon theme got merged in, while my commit adds a new icon that still comes from oxygen. Here's how it looks:
Update: two builds are still broken but I don't think I did it this time. |
|
Thanks. I'm concerned by the following: qBt does not use in-place configuration actions. Most of the settings are located in the settings dialog instead. And here you do quite the opposite. This does not seem to provide a seamless UI experience, right? From the other hand, ability to configure application fonts and colours might be useful, especially for those environments where there is no system-wide colour and font themes. As to me, a page in the option dialog where user can configure fonts and colours for the application would be a better choice. What do you think? |
|
@evsh, I completely agree with you. I wanted to put these into the configuration dialog but I couldn't find a good place for this and I didn't feel like two new settings deserve a separate "appearance" or "look & fell" page. If you can suggest the proper place for these settings I'll gladly move them. |
|
Uh, in my vision we need a new page with settings for:
As you see, this would result in much more work. |
|
I moved the font options to the options dialog to behavior section, here's how it looks:
|
Zalewa
changed the title
|
@Zalewa, so, no colours settings are planned? |
|
@evsh, I made the current changes because some monitor + screen resolution configurations combined with RDP are making the text really hard to read with the default font. This change is more due to necessity rather than desire for personal aesthetics. Sorry. If you feel this can be followed up with more customization options then I guess this here is a good start. I'll be making one more commit as I have discovered that table rows don't shrink when you launch the program with larger font already configured and then choose a smaller one. |
Fonts used in torrent list and execution log can now be changed through context menus of those widgets. These fonts are stored in configuration and restored upon next program run.
This variable cannot be cached anymore because the size of the font can now be changed during runtime.
|
Sorry, for late responses. Didn't read whole discussion. My old stance was "don't let the user configure colors,fonts,themes" etc, but as I see it is very hard to account for all hardware combinations and all user preferences. And after this PR, #6186 and #3936 I think it is time to create and extra tab in the Preferences window so the user can configure the Appearance to his heart desire. However, I don't know if you're willing to do it? Maybe @evsh or @magao are willing to do it(implement new tab).
@glassez didn't you have a similar PR open? I can't seem to find it. |
|
@sledgehammer999 @evsh @glassez @Zalewa I'd be willing to implement a new Appearance tab which simply aggregated all the existing appearance options and could then be used as the basis for other PRs to build on. I'll see if I can get to it this weekend. These are the options I think should be moved to Appearance: Behaviour/Language (which means Appearance should be the first tab so it's the first thing that shows up when the options opens). Behaviour/Transfer List/Use alternating row colors Behaviour/Transfer List/Hide zero and infinity values Behaviour/Desktop/Show splash screen on start up (not sure about this one - could fit in either category) Behaviour/Desktop/Start qBittorrent minimized + all sub-options (not sure about this one - could fit in either category) Behaviour/Desktop/Show qBittorrent in notification area (not sure about this one - could fit in either category) Advanced/Display notifications Advanced/Display notifications for added torrents (should this only be available if Display notifications is checked?) Advanced/Download tracker's favicon (rename to Show tracker's favicon?) Advanced/Use system icon theme (on linux this only seems to affect the notification area icon - should this only be |
|
IMO, these belong to Behavior:
Talking from memory here, but I think this also controls the icons for the toolbar and any other icon that follows the icon theme naming spec. |
|
I invite you to discuss the new options page in #6363 |
Fonts used in torrent list, torrent properties and execution
log can now be changed from "Behavior" section of options
dialog. These fonts are stored in configuration and restored
upon next program run.