Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling splitter resize client to server invocations #1509

Closed
wants to merge 1 commit into from

Conversation

iotalambda
Copy link

Fixes #1506. By setting ClientToServerInvocationsOnPaneResize = false, both the freezing problem and infinite memory consumption are gone and splitters resize smoothly, even if the render mode is interactive, there's network lag and there's complex content on the panes.

@enchev
Copy link
Collaborator

enchev commented May 20, 2024

Hey @iotalambda,

I'm unable to reproduce such problem:
splitter-resize

The change added to 4.27.0 was the StateHasChanged() invoke on resize which will recreate the panes content and this indeed might have performance hit depending on what you have. I'm not sure however that disabling this invoke is the proper solution and honestly I don't like the name ClientToServerInvocationsOnPaneResize. Maybe ChangePaneStateOnResize will be a better name.

@iotalambda
Copy link
Author

@enchev Hi, instead of this PR, I decided to implement a fully client side version of RadzenSplitter (with styling from the original splitter), so that all clicks and drags are handled in the client-side only, and it seems to solve the problem even better. I'm quite sure the lagginess occurs only if there's complex data on the panes and also some network latency. In case you want to introduce the fully client side alternative to the library, I can probably create a PR for it at some point.

@iotalambda iotalambda closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RadzenSplitter with lots of content freezes
2 participants