Convert numbers to words to obtain timing data from load_align_model() #135
+55
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louispan
force-pushed
the
louispan/numbers_to_words
branch
3 times, most recently
from
f0501dc
to
da98e65
Compare
louispan
force-pushed
the
louispan/numbers_to_words
branch
from
da98e65
to
61abf91
Compare
|
Cool!! |
- Added tests
rakuri255
requested changes
Jun 2, 2024
| @@ -80,6 +100,10 @@ def transcribe_with_whisper( | |||
| ) | |||
| sys.exit(1) | |||
|
|
|||
| # convert any numbers to words so align will have timing | |||
| for obj in result["segments"]: | |||
There was a problem hiding this comment.
It only works for English songs. With other languages you would have english words.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.