Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make download function work with non-US-ASCII characters #510

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lopatoid
Copy link

Fixed #441 . After this fix, you'll be able to use "download" function of Remi to download files with non-ASCII characters in the filename.

@dddomodossola
Copy link
Collaborator

Hello @lopatoid thank you very much. Can you please make it compatible with python2 ? I know that the world should switch to python3, but there are still lot of devices compatible only with python2 and remi aims to work everywhere.

@lopatoid
Copy link
Author

lopatoid commented Feb 21, 2023

I can, but the latest git version of Remi doesn't work with python2

python2 examples/widgets_overview_app.py
........
remi.server.ws   INFO     connection established: ('127.0.0.1', 41096)
remi.server.ws   DEBUG    handle
remi.server.ws   DEBUG    handshake
remi.server.ws   INFO     handshake complete
remi.server.ws   DEBUG    send_message: 0140142837... -> ('127.0.0.1', 41096)
remi.server.ws   ERROR    Error managing incoming websocket message
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/remi-2022.7.27-py2.7.egg/remi/server.py", line 175, in read_next_message
    opcode = head[0] & 0b1111
TypeError: unsupported operand type(s) for &: 'str' and 'int'
remi.server.ws   DEBUG    ws ending websocket service

@dddomodossola
Copy link
Collaborator

Hello @lopatoid thank you. Now I am abroad, I will review your changes when back to home on 4 March.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-latin support
2 participants