-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Remove some dead code from BlockList
#45398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
May 17, 2024 00:41
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
…nto dead-block-list Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
c21
approved these changes
May 20, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
This PR removes several methods from BlockList and LazyBlockList that aren't used anywhere. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
This PR removes several methods from BlockList and LazyBlockList that aren't used anywhere. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
This PR removes several methods from BlockList and LazyBlockList that aren't used anywhere. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com>
GabeChurch
pushed a commit
to GabeChurch/ray
that referenced
this pull request
Jun 11, 2024
This PR removes several methods from BlockList and LazyBlockList that aren't used anywhere. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Signed-off-by: gchurch <gabe1church@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR removes several methods from
BlockList
andLazyBlockList
that aren't used anywhere.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.