Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose FBO aspect #3957

Closed
wants to merge 1 commit into from
Closed

Conversation

pfeodrippe
Copy link

So we can customize the 3d mode if desired.

So we can customize the 3d mode if desired.
@pfeodrippe
Copy link
Author

For more context (and an example), I'm using this to read GLTF metadata and set the Camera rotation \o Let me know if this is okay.

@raysan5
Copy link
Owner

raysan5 commented May 5, 2024

@pfeodrippe Is it possible to do the same with GetRenderWidth() and GetRenderHeight()? I would prefer to avoid adding this specific function.

@pfeodrippe
Copy link
Author

Hi @raysan5, if you say that you could use GetRenderWidth and GetRenderHeight at

float aspect = (float)CORE.Window.currentFbo.width/(float)CORE.Window.currentFbo.height;
instead of referring to currentFbo, then yes, let me know if this will always be correct.

Thank you very much for the lib and review :D

@pfeodrippe
Copy link
Author

pfeodrippe commented May 10, 2024

@raysan5 So are they the same thing based on your 👍 ? Can we use, for example, CORE.Window.currentFbo.width and GetRenderWidth() interchangeably?

As GetRenderWidth() has width = (int)((float)CORE.Window.render.width*scale.x);, I was assuming that they could have different values \o

@raysan5
Copy link
Owner

raysan5 commented May 12, 2024

@pfeodrippe Afaik, there could be a difference when using RenderTextures but it should be analized more carefully. Still, I prefer not to expose the function on its current form. In any case, I'd prefer to update render size for RenderTexture if requried.

@raysan5 raysan5 closed this May 12, 2024
@pfeodrippe
Copy link
Author

@pfeodrippe Afaik, there could be a difference when using RenderTextures but it should be analized more carefully. Still, I prefer not to expose the function on its current form. In any case, I'd prefer to update render size for RenderTexture if requried.

Thanks o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants