Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user docs from cutter repository #2399

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

karliss
Copy link
Member

@karliss karliss commented Aug 18, 2020

Will be moved to separate repository.

Your checklist for this pull request

Detailed description

Remove the non code docs and add github action for building and uploading doxygen docs to radareorg/cutter.re

I have made a repository containing only docs here https://github.com/karliss/cutter-docs . It has the history and tags preserved, and also the changes to build and upload docs to radareorg/cutter.re .

Remaining work:

  • Discuss code documentation placement in cutter.re
  • Recreate the cutter-docs repo to include latest documentation changes from cutter master, once rest of the tasks are resolved
  • Update the upload paths, currently uploading to test repo to debug the scripts
  • Configure the secrets and deploy key for deploy scripts to work (only owners can do this)

Test plan (required)

Closing issues

Closes #2056

Will be moved to separate repository.
@karliss karliss changed the title Remove user docs. Remove user docs from cutter repository Aug 18, 2020
@karliss karliss mentioned this pull request Aug 20, 2020
3 tasks
@karliss
Copy link
Member Author

karliss commented Aug 20, 2020

I would like to hear the opinion about folder structure where to place doxygen output. I think it should be done keeping in mind that in future we might want to have multiple copies of it one for latest master and one for tag . Maybe seperate one which includes all the private stuff for Cutter developers and contributors as an alternative approach for exploring the code base.

Both due to versioning considerations and simplfying the upload process it would be easier to have it outside the folder uploaded by cutter-docs -> cutter.re/docs folder. To minimize the existing link breakage I don't think the regular docs should be moved.

I suggest something like:

  • cutter.re/docs -> content doesn't change
  • cutter.re/doc/api/latest -> doxygen output, we can later decide what latest means

This allows in future adding if necesarry

  • cutter.re/doc/[something?]/(version|latest|stable) - versioned main documentation
  • cutter.re/doc/api/version - versioned api doc
  • cutter.re/doc/(doxygen|code-all)/(latest) - doxygen output from all the code including internal parts

Alternative approach might be to upload it to separate folders as suggested above but do some jekyll config magic to ensure that it appears bellow cutter.re/docs/something when visiting the side. I don't think that's worth it.

@ITAYC0HEN
Copy link
Member

Having both /docs and /doc is a big no-no. Every UX person will tell you that.
Will attend this issue later on the coming week wit more thoughts.
But overall, I agree with using versioning and I am fine with splitting things to different tress, although I'd love keeping to only /docs and then add folder on top of it.

Alternatively, we can have docs.cutter.re

@karliss
Copy link
Member Author

karliss commented Aug 24, 2020

If you are the completely against having docs+doc. Then how about the approach of moving some things to the top level that is cutter.re/api/latest`?

If you consider URL an interface then an important property of it that links should remain valid as much as possible.

What problem do you want to solve using subdomain?
a) havbe both dos.cutter.re and cutter.re/docs -> same problem as with docs+doc
b) create docs.cutter.re and remove cutter.re/docs -> older links to documentation are broken. If you are fine breaking links we might as well reorganize the structure bellow cutter.re/docs to support versions and easier uploading.

@ITAYC0HEN
Copy link
Member

If you are fine breaking links we might as well reorganize the structure bellow cutter.re/docs to support versions and easier uploading.

I am fine with breaking docs structure at this point :) Just need to google-search and Github-search properly before

I am not at all against https://cutter.re/api/latest

@Surendrajat
Copy link
Member

@karliss @ITAYC0HEN is it a good time to address this one too? :)

@Surendrajat Surendrajat added this to the 2.0.0 milestone Feb 5, 2021
@Surendrajat Surendrajat mentioned this pull request Mar 1, 2021
3 tasks
@thestr4ng3r thestr4ng3r changed the base branch from master to dev December 21, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move written docs to rizinorg/cutter.re
3 participants