Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reload wallpapers button (tray menu) #1822 #1917

Closed

Conversation

Ju1-js
Copy link

@Ju1-js Ju1-js commented Oct 1, 2023

Initial Problem

When I was developing html wallpapers for lively awhile back, I found that I had no easy way to reload/refresh the wallpapers without the app open.

Proposed solution

Adds a "reload wallpapers" button to the tray menu, only in english for now, other languages will have to be translated.

Alternatives

I used to just leave the app open and right click -> set as wallpaper to reload it like: #1689

Ps. I came back to this though when I was looking through issues and found #1822

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2023

CLA assistant check
All committers have signed the CLA.

@rocksdanister
Copy link
Owner

I don't feel there is a need for separate UI since SetWallpaper command to reload:
https://github.com/rocksdanister/lively/wiki/Command-Line-Controls#set-wallpaper

Also ResetWallpaper shutsdown everything and restarts, its not meant to be used to reload wallpaper.

> I don't feel there is a need for separate UI since `SetWallpaper` command to reload: [rocksdanister/lively/wiki/Command-Line-Controls#set-wallpaper](https://github.com/rocksdanister/lively/wiki/Command-Line-Controls#set-wallpaper)
>
> Also ResetWallpaper shutsdown everything and restarts, its not meant to be used to reload wallpaper.

New commit essentially duplicates [desktopCore.ResetWallpaper](https://github.com/rocksdanister/lively/blob/9692ec07f3468bd9e337f11f37ce5c36282504ec/src/Lively/Lively/Core/WinDesktopCore.cs#L576C26-L576C26), but doesn't terminate everything.
@Ju1-js
Copy link
Author

Ju1-js commented Oct 1, 2023

I don't feel there is a need for separate UI since SetWallpaper command to reload: rocksdanister/lively/wiki/Command-Line-Controls#set-wallpaper

Also ResetWallpaper shutsdown everything and restarts, its not meant to be used to reload wallpaper.

New commit essentially duplicates desktopCore.ResetWallpaper, but doesn't terminate everything.

I'll also look into simply firing a command at lively on save in terms of the workflow, but I think I could be nice to have a dedicated button for reloading things.

@Ju1-js Ju1-js mentioned this pull request Dec 17, 2023
@Ju1-js
Copy link
Author

Ju1-js commented Dec 17, 2023

You're probably right in assuming that most wallpapers aren't going to need to be reloaded, it would mostly be html based ones.
However I feel it could be nice for anyone wanting to restore their html wallpaper to it's original state without opening the ui.

@rocksdanister
Copy link
Owner

rocksdanister commented May 26, 2024

Similar to random just added a reload wallpaper command for setwp to make it easy 41af1d7

Along with future hotkey support which will let users register custom lively commandline commands directly: #665

I feel this is better and more versatile than adding too many options in the interface, therefore I am closing this.

@Ju1-js Ju1-js deleted the Reload-Wallpapers branch May 27, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants