desktop: Add screenshot functionality to the desktop app #13719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OctoCPPlus
changed the title
| @@ -193,6 +195,13 @@ impl RuffleGui { | |||
| player.set_volume(self.volume_controls.get_volume()); | |||
| } | |||
|
|
|||
| fn is_taking_screenshot(&mut self) -> bool { | |||
There was a problem hiding this comment.
The name is_taking_screenshot sounds like this method doesn't change the state- could this just return self.taking_screenshot? (I think this approach would require adding a set_taking_screenshot function)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to take a screenshot of the stage using a button.
Feel free to suggest edits and changes, this code may be messy in places: I've never used rust before.