core: Fix mouseWheel event not being dispatched in AVM2
#14550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
force-pushed
the
avm2-fix-mousewheel
branch
from
3b37c19
to
0104966
Compare
|
Flash docs say delta "depends on the device and operating system and is usually configurable by the user" - guessing it depends on this setting on Windows? |
|
Is that setting at 3 by default? I'm on Linux and I assumed FP kept consistent behavior throughout the Windows and Linux builds. |
|
Yes, 3 is the default on windows. |
|
I've opened an issue for the delta problem: #14795. It's a preexisting issue so it shouldn't block this PR. |
Dinnerbone
added
waiting-on-author
|
(waiting for the mentioned test :D) |
torokati44
added
avm2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to add a test for this.
I'm not sure why, but the wheel event being dispatched is jittery for me. I'd appreciate manual testing with games that use the mouse wheel (e.g. Scratch 2). Additionally, kmeisthax's comment on #5767 seems relevant- at least I can reproduce it:
If anyone else can reproduce that Ruffle scrolls less than Flash, I can make the change to multiply the reported delta by 3.