Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension: Localize strings in player.html #14628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Toad06
Copy link
Member

@Toad06 Toad06 commented Jan 5, 2024

No description provided.

@Dinnerbone
Copy link
Contributor

I'm a bit torn :D I like this and very much want this, but we've just put a lot of work into making ruffle.rs/demo the same code as this, with the intent to reuse the demo page as a library.

We could just take this and figure it out later, but the strings will have to move to their own package later and on crowdin that means deleting and making new - losing any progress between now and then.

I'm not sure :(

@torokati44
Copy link
Member

We could just take this and figure it out later, but the strings will have to move to their own package later and on crowdin that means deleting and making new - losing any progress between now and then.

Sure, but we had a similar thing after the extension redesign - then I simply copied the translated strings over. I can do that again if we go this route. Not the most pleasant thing to do manually, but not a big deal either.

@torokati44 torokati44 added extension Related to the Ruffle WebExtension localization Translations and other localisation labels Jan 26, 2024
@Toad06
Copy link
Member Author

Toad06 commented Feb 2, 2024

For now, I could remove the translations for strings that are only meant for debbuging ("Uncompressed Length", "SWF Version", etc.). This should make the transition to their own package less painful. What do you guys think?

Sorry for the late reply, by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Related to the Ruffle WebExtension localization Translations and other localisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants