core: Remove LoaderHandle when load is done #15115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
approved these changes
Feb 7, 2024
In almost all cases, we were letting completed LoaderHandles accumulate, leaking memory and wasting time in `preload_tick`
Dinnerbone
force-pushed
the
loader-cleanup
branch
from
19edd43
to
c8f4cb6
Compare
|
Sorry, maybe reviewed too quickly. I notice that some places have the potential to return early with Is there another way we can do this? |
| @@ -24,6 +24,12 @@ use super::Avm2; | |||
| #[collect(no_drop)] | |||
| pub struct Domain<'gc>(GcCell<'gc, DomainData<'gc>>); | |||
|
|
|||
| impl std::fmt::Debug for Domain<'_> { | |||
There was a problem hiding this comment.
Accidentally added?
There was a problem hiding this comment.
My guess is Aaron added it, much like the Debug impls later on, while debugging the memory problems caused by not cleaning up loaders.
I'm personally fine with merging the debug impls alongside everything else. Not being able to trace something because someone forgot to add a Debug impl is frustrating.
danielhjacobs
added
the
waiting-on-author
|
I'm wondering if we can abuse RAII/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In almost all cases, we were letting completed LoaderHandles accumulate, leaking memory and wasting time in
preload_tick