core: Remove time limit from ExecutionLimit #15550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time limit check was inherently non-deterministic. Since the 'progress' events depend on how often the execution limit is hit (which determines how many frames a movie will take to preload), runtime behavior could change between different machines. In the case of Spinin, my lazy-image-decoding change made preloading fast enough (in terms of wall-clock time) that the entire movie preloaded at once, breaking the game.
| pub fn did_ops_breach_limit( | ||
| &mut self, | ||
| context: &mut UpdateContext<'_, '_>, | ||
| _context: &mut UpdateContext<'_, '_>, |
There was a problem hiding this comment.
Can the context parameter can be removed from here now?
There was a problem hiding this comment.
Note that there's been quite some discussion about the point or validity of this PR on Discord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time limit check was inherently non-deterministic. Since the 'progress' events depend on how often the execution limit is hit (which determines how many frames a movie will take to preload), runtime behavior could change between different machines.
In the case of Spinin, my lazy-image-decoding change made preloading fast enough (in terms of wall-clock time) that the entire movie preloaded at once, breaking the game.