desktop: Do not resize the window while it is maximized #15966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing the original issue now, I notice that on Windows, loading an SWF into a maximized window does result in a resize, but the window doesn't realize that it is now unmaximized, so it takes two clicks to maximize the window again: ruffle_24ycUiMAYa.mp4I guess we should look into fixing this behavior, maybe in a followup. (I can open a new issue if this doesn't seem easy to solve) |
|
Maybe we shouldn't try to resize the window at all when it is maximized? |
|
Sounds good to me! |
sleepycatcoding
force-pushed
the
dont_maximize_sleep_time
branch
from
1db76fb
to
5cf7fae
Compare
|
@n0samu could you test the changes on Windows to see if it fixes the window desync. (I don't have a Windows environment to test myself) |
sleepycatcoding
force-pushed
the
dont_maximize_sleep_time
branch
from
5cf7fae
to
16868a3
Compare
|
Just tested and it's working well now, thanks! 👍 |
sleepycatcoding
changed the title
sleepycatcoding
force-pushed
the
dont_maximize_sleep_time
branch
4 times, most recently
from
48817d6
to
1e46b8b
Compare
sleepycatcoding
added
the
waiting-on-review
torokati44
force-pushed
the
dont_maximize_sleep_time
branch
from
1e46b8b
to
a06ff25
Compare
sleepycatcoding
force-pushed
the
dont_maximize_sleep_time
branch
from
a06ff25
to
ad32926
Compare
sleepycatcoding
force-pushed
the
dont_maximize_sleep_time
branch
from
ad32926
to
0d7acdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11364.