Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2e): migrate off circleci #4576

Merged
merged 10 commits into from
May 20, 2024
Merged

feat(e2e): migrate off circleci #4576

merged 10 commits into from
May 20, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented May 18, 2024 •
edited

@chenrui333

This comment was marked as resolved.

Sign in to view
@chenrui333

This comment was marked as resolved.

Sign in to view
@chenrui333
feat: migrate off circleci
a7e83ef 
Signed-off-by: Rui Chen <rui@chenrui.dev>

update deps

Signed-off-by: Rui Chen <rui@chenrui.dev>

update ngrok to v3

add NGROK_AUTH_TOKEN

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 marked this pull request as ready for review May 18, 2024 23:28
@chenrui333 chenrui333 requested review from a team as code owners May 18, 2024 23:28
@chenrui333 chenrui333 requested review from jamengual, lukemassa and nitrocode and removed request for a team May 18, 2024 23:28
@chenrui333
Copy link
Member Author

two test PRs:

@chenrui333 chenrui333 changed the title feat: migrate off circleci feat(e2e): migrate off circleci May 18, 2024
@chenrui333
remove some debug setup
c02c95d 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
add set -euo pipefail back
d304cbd 
Signed-off-by: Rui Chen <rui@chenrui.dev>
jippi
jippi reviewed May 19, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
jippi
jippi reviewed May 19, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
jippi
jippi reviewed May 19, 2024
View reviewed changes
scripts/e2e.sh
@@ -20,14 +15,15 @@ cd "${CIRCLE_WORKING_DIRECTORY}/e2e"
sleep 2

# start ngrok in the background and wait for it to start
./ngrok config add-authtoken $NGROK_AUTH_TOKEN
./ngrok http 4141 > /tmp/ngrok.log &
./ngrok config add-authtoken $NGROK_AUTH_TOKEN > /dev/null 2>&1
Copy link
Contributor

@jippi jippi May 19, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any cases where this might fail and having the stderr output would be useful for debugging, rather than being suppressed?

If we captured the combined output; and only print it if $? is not 0 from it; we would get the best of both worlds.

Alternatively could this be moved into the Setup deps step as part of the installation and keeping them together (letting GH deal with hiding the output by default when things are successful).

Moving it into the pipeline would also reduce NGROK_AUTH_TOKEN env from a all steps has this to Setup ngrok step can access it; limiting possible exposure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same deal as version management, if it failed or does not work for any reason, we will probably debug directly inside the container though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could just bring some echo statement back so that we know this step does not work (that is why I disabled all the outputs in here)

jippi
jippi reviewed May 19, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
jippi
jippi reviewed May 19, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
jippi
jippi reviewed May 19, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
jippi
jippi reviewed May 19, 2024
View reviewed changes
scripts/e2e.sh Outdated Show resolved Hide resolved
chenrui333 and others added 5 commits May 19, 2024 10:46
@chenrui333
update bot email address
2cf8597 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
use env.TERRAFORM_VERSION for version ref
395e5da 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 @jippi
use ngrok rather than deps
ffd7ac3 
Co-authored-by: Christian Winther <jippignu@gmail.com>
@chenrui333 @jippi
add fallback for GITHUB_WORKSPACE ref
5baa633 
Co-authored-by: Christian Winther <jippignu@gmail.com>
@chenrui333 @jippi
improve e2e test job name
db089df 
Co-authored-by: Christian Winther <jippignu@gmail.com>
@github-actions github-actions bot added the go Pull requests that update Go code label May 19, 2024
@chenrui333
replace GITHUB_PASSWORD with ATLANTISBOT_GITHUB_TOKEN
50ff2ff 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Member Author

should be good to go.

jippi

This comment was marked as resolved.

Sign in to view

360rb

This comment was marked as spam.

Sign in to view

GenPage
GenPage approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@GenPage GenPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some of @jippi comments are pretty valid. Feel free to proceed but I want to make sure we address them in some form as long as it's non-blocking.

@chenrui333 chenrui333 merged commit 7e79f56 into main May 20, 2024
27 checks passed
@chenrui333 chenrui333 deleted the e2e-test-migration-2024 branch May 20, 2024 16:02
@jippi
Copy link
Contributor

jippi commented May 20, 2024

LGTM, some of @jippi comments are pretty valid. Feel free to proceed but I want to make sure we address them in some form as long as it's non-blocking.

Going to include some of @jippi comments are pretty valid as a quote in my next performance review 🤣

chenrui333 added a commit that referenced this pull request May 25, 2024
@chenrui333
chore: cherry-pick #4576 (e2e update) into release-0.27
84cb076 
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333 added a commit that referenced this pull request May 25, 2024
@chenrui333
chore: cherry-pick #4576 (e2e update) into release-0.27
3e78a1b 
Signed-off-by: Rui Chen <rui@chenrui.dev>

chore: add another patch for fix forked PR run issue

Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333 added a commit that referenced this pull request May 27, 2024
@chenrui333
chore: cherry-pick #4576 (e2e update) into release-0.27 (release-0.27) (
a2b1451 
#4607)

Signed-off-by: Rui Chen <rui@chenrui.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jippi jippi jippi approved these changes

@jamengual jamengual jamengual approved these changes

@GenPage GenPage GenPage approved these changes

@nitrocode nitrocode nitrocode approved these changes

@GMartinez-Sisti GMartinez-Sisti GMartinez-Sisti approved these changes

@360rb 360rb 360rb approved these changes

@lukemassa lukemassa Awaiting requested review from lukemassa lukemassa is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
github-actions go Pull requests that update Go code size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircleCI e2e "branch" checks are cancelled intermittently after merging a PR
7 participants
@chenrui333 @jippi @jamengual @GenPage @nitrocode @GMartinez-Sisti @360rb