Migrate run-make/issue-30063 to rmake
#125227
Merged
+38
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Some changes occurred in run-make tests. cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jieyouxu
reviewed
May 17, 2024
Comment on lines
3
to
4
| // This test tries to reproduce this issue with varied emit flags - if it passes, the codegen-units | ||
| // are being appropriately reset to 1 after each pass. |
There was a problem hiding this comment.
AFAICT, this isn't actually being checked. We're just checking here that foo.rs "compiles with various cli flags", am I understanding that correctly?
There was a problem hiding this comment.
As in, the original test also isn't checking what this comment is saying?
There was a problem hiding this comment.
You're right, I wrongfully assumed. The test is checking that the fix did not break compilation, not that the fix itself is doing what it is supposed to do (preventing the annoying re-compilation).
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
May 17, 2024
…jieyouxu Migrate `run-make/issue64319` to `rmake` and rename Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). ~~I noticed that the Makefile was not listed in `allowed-run-makefiles` in Tidy. Does this mean the test was being ignored?~~ EDIT: No, it was there, just not in its expected alphabetical order. EDIT2: Perhaps it could be interesting to clean this test visually by looping over the `rustc` calls, like in rust-lang#125227.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2024
Rollup merge of rust-lang#125215 - Oneirical:easy-test-the-second, r=jieyouxu Migrate `run-make/issue64319` to `rmake` and rename Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). ~~I noticed that the Makefile was not listed in `allowed-run-makefiles` in Tidy. Does this mean the test was being ignored?~~ EDIT: No, it was there, just not in its expected alphabetical order. EDIT2: Perhaps it could be interesting to clean this test visually by looping over the `rustc` calls, like in rust-lang#125227.
|
☔ The latest upstream changes (presumably #125233) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
jieyouxu
reviewed
May 21, 2024
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Revisions made. @rustbot review |
rustbot
added
S-waiting-on-review
|
Thanks, r=me after squashing commits into one. |
|
✌️ @Oneirical, you can now approve this pull request! If @jieyouxu told you to " |
bors
added
S-waiting-on-bors
|
@bors rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 23, 2024
Migrate `run-make/issue-30063` to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). (Sorry about the [inconvenience](rust-lang#125224 (comment)) of all these PRs, this is the last one batched for today. I will discuss how we can cut these down a bit.) The last check was previously commented out in the Makefile, and I have readded it. If it fails the CI, this can be reconsidered.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#125165 (Migrate `run-make/pgo-branch-weights` to `rmake`) - rust-lang#125210 (Cleanup: Fix up some diagnostics) - rust-lang#125224 (Migrate `run-make/issue-53964` to `rmake`) - rust-lang#125227 (Migrate `run-make/issue-30063` to `rmake`) - rust-lang#125383 (Rewrite `emit`, `mixing-formats` and `bare-outfile` `run-make` tests in `rmake.rs` format) - rust-lang#125401 (Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`) - rust-lang#125409 (Rename `FrameworkOnlyWindows` to `RawDylibOnlyWindows`) - rust-lang#125416 (Use correct param-env in `MissingCopyImplementations`) - rust-lang#125421 (Rewrite `core-no-oom-handling`, `issue-24445` and `issue-38237` `run-make` tests to new `rmake.rs` format) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 23, 2024
Migrate `run-make/issue-30063` to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). (Sorry about the [inconvenience](rust-lang#125224 (comment)) of all these PRs, this is the last one batched for today. I will discuss how we can cut these down a bit.) The last check was previously commented out in the Makefile, and I have readded it. If it fails the CI, this can be reconsidered.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#125210 (Cleanup: Fix up some diagnostics) - rust-lang#125224 (Migrate `run-make/issue-53964` to `rmake`) - rust-lang#125227 (Migrate `run-make/issue-30063` to `rmake`) - rust-lang#125383 (Rewrite `emit`, `mixing-formats` and `bare-outfile` `run-make` tests in `rmake.rs` format) - rust-lang#125401 (Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`) - rust-lang#125409 (Rename `FrameworkOnlyWindows` to `RawDylibOnlyWindows`) - rust-lang#125416 (Use correct param-env in `MissingCopyImplementations`) - rust-lang#125421 (Rewrite `core-no-oom-handling`, `issue-24445` and `issue-38237` `run-make` tests to new `rmake.rs` format) - rust-lang#125438 (Remove unneeded string conversion) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#122382 (Detect unused structs which implement private traits) - rust-lang#124389 (Add a warning to proc_macro::Delimiter::None that rustc currently does not respect it.) - rust-lang#125224 (Migrate `run-make/issue-53964` to `rmake`) - rust-lang#125227 (Migrate `run-make/issue-30063` to `rmake`) - rust-lang#125336 (Add dedicated definition for intrinsics) - rust-lang#125401 (Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`) - rust-lang#125454 (Improve the doc of query associated_item) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2024
Rollup merge of rust-lang#125227 - Oneirical:seventh, r=jieyouxu Migrate `run-make/issue-30063` to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). (Sorry about the [inconvenience](rust-lang#125224 (comment)) of all these PRs, this is the last one batched for today. I will discuss how we can cut these down a bit.) The last check was previously commented out in the Makefile, and I have readded it. If it fails the CI, this can be reconsidered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876 and the associated Google Summer of Code project.
(Sorry about the inconvenience of all these PRs, this is the last one batched for today. I will discuss how we can cut these down a bit.)
The last check was previously commented out in the Makefile, and I have readded it. If it fails the CI, this can be reconsidered.