[master] Fix shell.KEY_VALID_RE to match host authenticity message. Fixes #62782 #66326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell.KEY_VALID_RE regex only matches messages containing '(yes/no)', and not messages containing '(yes/no/[fingerprint])' This leads to the salt-ssh command hanging, (Shell._run_cmd waits for data on stdout) while the ssh command is waiting on input.
Fix by updating the KEY_VALID_RE regex to match both prompts
What does this PR do?
Fixes a bug where salt-ssh hangs (waiting for more output), while ssh is waiting on input from user.
What issues does this PR fix or reference?
Fixes #62782
Previous Behavior
When output containing
(yes/no)
is found, salt-ssh exits and prints the output from ssh about host authenticityNew Behavior
When output containing
(yes/no)
or(yes/no/[fingerprint])
is found, salt-ssh exits and prints the output from ssh about host authenticityMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.