-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify that lint is wconfable #10756
base: 2.13.x
Are you sure you want to change the base?
Conversation
I think dotty test rig has a mechanism for "test with and without flag"; at some point it resulted in an explosion of test runs, which points to its facility. Here, it would be nice to automate that neg test has Worth noting that I added a pos test from OP on another branch last week, so I added it locally and mistyped it: I forgot I know the useful actions s, w, and e, because I am a SWE. |
test/files/neg/cloneable.scala
Outdated
@@ -1,5 +1,6 @@ | |||
|
|||
//> using options -Werror -Xlint:cloneable | |||
//> using test.options --recompile=-Wconf:cat=lint-cloneable:s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about //> using retest.options -Wconf:cat=lint-cloneable:s
. Leverage the "scope"; don't pollute semantics of test.options
which I assume means compile options for tests, which is technically redundant here; also avoids the awkward --recompile
; but the semantics of retest
are constrained, as it doesn't mean "retest as neg" but "as pos", or maybe it would also invert pos to neg on retest.
@SethTisue This evening while watching the Great Courses disc on American History, I learned about the War of Jenkins' Ear, which must interest you for the obvious and only reason. |
I deleted the coursier cache for now
|
Yeah the usual solution is to blow away community build workspaces. We do blow away the dbuild cache occasionally but it's needed less often. |
👍 can this be done at any time or does it cause more work for you right now close to the release? |
if I'm unavailable (as I was for 24 hours or so in this case, though I'm now available again) you should feel free to just do it if I'm available, I can sometimes be selective about only blowing away a workspace that doesn't have partial results that we'd prefer to keep in order to save time. but it's only about saving time waiting for results, rather than about whether it makes more work one thing about blowing away a workspace is that the number of files involved is so large that sometimes the behemoth will shut down before the |
I sometimes go into the node config and change the Idle delay. It's 5 minutes by default. |
Fixes scala/bug#12985
Emits the warning in a lint category.
Adds an internal feature for partest:
using test.option --recompile
allows checking that a neg test turns pos when recompiled with an additional option (-Wconf:something
).toolArgs
is teased apart to encourageusing
syntax, which is easier to parse (than checking for all the tool names).