Closes #6365. Fix overridable methods in MediaPipeline #6368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar-sanchay
force-pushed
the
override-methods
branch
from
3b534a0
to
60743d0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6368 +/- ##
===========================================
- Coverage 85.00% 43.85% -41.16%
===========================================
Files 161 162 +1
Lines 11962 12114 +152
Branches 1872 1904 +32
===========================================
- Hits 10168 5312 -4856
- Misses 1512 6425 +4913
- Partials 282 377 +95
|
kumar-sanchay
force-pushed
the
override-methods
branch
4 times, most recently
from
11fcff5
to
e51c517
Compare
wRAR
reviewed
May 19, 2024
wRAR
reviewed
May 19, 2024
kumar-sanchay
force-pushed
the
override-methods
branch
6 times, most recently
from
16f7c7d
to
0a45703
Compare
wRAR
reviewed
May 20, 2024
kumar-sanchay
force-pushed
the
override-methods
branch
from
0a45703
to
3959d69
Compare
wRAR
reviewed
May 21, 2024
| fail = Failure(Exception()) | ||
| assert self.pipe.media_failed(fail, request, self.info) is fail | ||
|
|
||
| def test_default_item_completed(self): |
There was a problem hiding this comment.
This is also useful and should be kept.
There was a problem hiding this comment.
Ah yes you are right !
Still trying to understand the project :)
kumar-sanchay
force-pushed
the
override-methods
branch
from
3959d69
to
40cae19
Compare
Gallaecio
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6365