Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new false positives #2107

Merged
merged 2 commits into from May 9, 2024

Conversation

ppfeister
Copy link
Collaborator

@ppfeister ppfeister commented May 8, 2024

[ title, or see commit messages ]

Also closes #951 (adds linktree. linktree already added and is being fixed here.)

CNET appears to have changed some things...
'null null' text has been removed with a redesign, and invalid users now return a 404 so we don't need a whole GET and English-only check.
Linktree only permits usernames with the given regex and 404s otherwise
Copy link
Member

@sdushantha sdushantha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sdushantha sdushantha merged commit 3d283b6 into sherlock-project:master May 9, 2024
2 checks passed
@ppfeister ppfeister deleted the bugfix/false-pos branch May 10, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants