Add support for Mitsubishi MSZ-AP**VGD/VGK2 series ACs #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the following Mitsubishi Elecric split systems: - MSZ-AP25VDG2 (swing mode) - MSZ-AP25VDKG2 (swing mode) - MSZ-AP35VDG2 (swing mode) - MSZ-AP35VDKG2 (swing mode) - MSZ-AP42VDG2 (swing mode) - MSZ-AP42VDKG2 (swing mode) - MSZ-AP50VDG2 (swing mode) - MSZ-AP50VDKG2 (swing mode) - Econo cool mode does not support changing swing modes (to fit within the operationMode > fanMode > swingMode > temperature structure, duplicate codes have been added) - Dry mode does not support changing temperature (all temperature specific codes are duplicates for this mode) - Heat mode supports temperatures as low as 10 (only temperatures between 16-31 have been added) - Fan mode does not support changing temperature (all temperature specific codes are duplicates for this mode)
autoformatter got me.
|
hey @vassilis-panos is there anything i can do to make this easier to review? |
|
hey @vassilis-panos ! just checking in. Can I do anything to help out here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the following Mitsubishi Electric split systems:
Notes