Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.1-MIDI-In language reworked #2443

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from

Conversation

comradekingu
Copy link
Contributor

Moved to main from #2007

default. (Note that this added latency can be configured via the fns
`set_sched_ahead_time!` and `use_sched_ahead_time`). This 0.5s latency
is being added to our `:piano` synth triggers as it is added to all
synths triggered by Sonic Pi. Typically we really want this added
latency as it means all synths will be well timed. However, this only
makes sense for synths triggered by code using `play` and `sleep`. In
this case, we're actually triggering the `:piano` synth with our
external MIDI device and therefore don't want Sonic Pi to control the
external MIDI device. and therefore don't want Sonic Pi to control the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we add a . here the following word should be capitalized ?

@samaaron
Copy link
Collaborator

Hi, thanks for this.

I’m currently very happy with the informal voicing of the documentation. However, I am interested in grammar, punctuation fixes and rewording where things are particularly unclear to the reader.

If you could constrain your changes to these then I’d be happy to consider it. As it currently stands these changes feel like they deviate too far from something I’d write :-)

button and see if it appears. If you're still not seeing anything,
the next thing to try is to consult your operating system's MIDI config
to see if it sees your device. Failing all that, feel free to ask
questions in the public chat room: http://gitter.im/samaaron/sonic-pi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the gitter chat is mainly for development chat? The in-thread forums or maybe the GitHub issues page may be more suitable here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Additionally, the gitter chat room is pretty much obsolete now, and we will always point folks elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants