[Server] Show filepath in errors #2514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My tests of the PR on my Debian 10 desktop yield this result: |
|
@samaaron what do you think? :) Also, does the sonic-pi/app/server/ruby/lib/sonicpi/runtime.rb Lines 790 to 792 in 1b5d922 |
Should hopefully fix sonic-pi-net#2336
… immutable' errors
SunderB
force-pushed
the
patch/show-filepath-in-errors
branch
from
1b5d922
to
200fa77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes the file path in error messages when an error occurs in an external file (via run_file), and
Should hopefully fix #2336
Fixes a server crashing bug in the original PR (#2470)
Testing checklist
Screenshots (if appropriate):
Types of changes
Bug fix (non-breaking change which fixes an issue)