Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows MSI installer: make install directory configurable #2791

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SunderB
Copy link
Contributor

@SunderB SunderB commented Jun 23, 2021

(Hopefully) allows the user to choose the installation directory instead of always installing in Program Files.
Closes issue #2782 and discussion #2774

I'm not familiar with WIX or how it works, but I found this: https://wixtoolset.org/documentation/manual/v3/wixui/dialog_reference/wixui_installdir.html which is what I've based this PR from.
This has not been tested yet. Testing is greatly appreciated!

@ethancrawford
Copy link
Collaborator

Looks great! I'll test this out in a week or so unless someone else gets to it before me 😄

@ethancrawford
Copy link
Collaborator

It's been a bit more than a week 😂 I've been quite busy recently... will report how I go in the next few days 👍

@ethancrawford
Copy link
Collaborator

So, initial tests show that it displays a dialog for picking the install directory.
However, when it finishes the install process, it appears to still install into the original program files location.
I'll see if I can troubleshoot this a little more.

@ethancrawford
Copy link
Collaborator

I don't know whether it's related, but when picking the directory to install to, I get this error: (which apparently comes from Windows Installer). Clicking Ok seems to still allow me to move on to the next stage of the installer.

Screenshot 2021-09-15 211616

The end result is still as in my above message.

If I do something drastic like remove the wrapping <Directory Id="ProgramFiles64Folder" Name="PFiles"> in sonic-pi.wxs, then it seems to put Sonic Pi in the chosen location, but the app crashes on starting.
I also saw an article that seemed to say that the ids of the nested directories should all not be in uppercase, but if I change them to lowercase, it makes no difference for me.

@ethancrawford ethancrawford added this to Blocked in Sonic Pi features Sep 18, 2021
@ethancrawford ethancrawford linked an issue Oct 12, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Feature Request: Custom Installation Location for Windows MSI
2 participants