-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP french dataset #2459
base: develop
Are you sure you want to change the base?
WIP french dataset #2459
Conversation
50eb05e
to
6348a56
Compare
0f03caf
to
b350fad
Compare
Squashed commits from pchampio to avoid storing HF model junk in the repository (still have a backup of the branch somewhere)
97a0252
to
fccb474
Compare
Squashed the commit into one so that the removed pretrained HF model stuff doesn't make it to the history; looking into the other CI issues (which seems to be because of old yaml that breaks due to the changes in the train scripts) and will try to test soon |
This seemed to be removed with the assumption that it was unused, but some yaml scripts in the trunk actually relies on it. Since this doesn't actually do anything if the hparams is specified, include it back.
@asumagic @Adel-Moumen PR ready for review. |
We will both be somewhat unavailable/busy in the near future but I will try to review by the end of this month. |
LM done
What does this PR do?
Add recipe for common french elra datasets
Before submitting
PR review
Reviewer checklist