-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean backends interface #434
base: master
Are you sure you want to change the base?
Conversation
Are you interessed in this pull request? |
I think removing global vars is definitely a good thing. I'm not sure I get the benefits of the inheritance approach. It seems to add some more boilerplate to creating a new backend. Can you elaborate a bit on the reasoning for this change? |
In this way each backends describe which events are listened. For the removing all grlobal variable, I'm preparing another pull request to clean stast.js file (https://github.com/allevo/statsd/commits/feature/refactorize-stast). ASAP I'll do pull request if you are interested... |
Use method as callback in readConfigFile Use method ad callback in onUdpPacketReceived
which changes are you interested? |
Use inheritance to define an interface for backends
Remove global variables.
Remove all jshint warning where possible.
Add graphite utility.