Modifications to allow building of toolset in OpenBSD #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightwalker-87
approved these changes
May 12, 2024
Nightwalker-87
changed the title
Ant-ON
reviewed
May 13, 2024
| @@ -1172,7 +1172,7 @@ stlink_t *stlink_open_usb(enum ugly_loglevel verbose, enum connect_type connect, | |||
|
|
|||
| if (ret) { continue; } // could not open device | |||
|
|
|||
| uint32_t serial_len = stlink_serial(handle, &desc, sl->serial); | |||
| uint32_t serial_len = (uint32_t)stlink_serial(handle, &desc, sl->serial); | |||
There was a problem hiding this comment.
I would simply change the type of serial_len variable to size_t.
There was a problem hiding this comment.
@Ant-ON: We could alternatively also change stlink_serial() to uint32_t.
This should be safe on all common architectures as well.
| @@ -1375,7 +1375,7 @@ static uint32_t stlink_probe_usb_devs(libusb_device **devs, stlink_t **sldevs[], | |||
| break; | |||
| } | |||
|
|
|||
| uint32_t serial_len = stlink_serial(handle, &desc, serial); | |||
| uint32_t serial_len = (uint32_t)stlink_serial(handle, &desc, serial); | |||
|
@Ilgrim: Please address these points in order to proceed. |
|
@Nightwalker-87 Sure! I will make the suggested changes 🙂 |
|
@Ilgrim: I'm looking forward to merge this PR in order to proceed... |
Nightwalker-87
approved these changes
May 29, 2024
|
I'll merge this with additional changes afterwards, as missing care on this PR delays unnecessarily delays any further proceedings. 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using OpenBSD for some microcontroller work and I needed these tools. As far I was not able to compile with the vanilla code, I have modified just a little for be able to compile in OpenBSD 7.4. Build tested in OpenBSD 7.4 and Debian 12.5.
I hope this can be somehow useful.