Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework create-strapi-xxx #20268

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Rework create-strapi-xxx #20268

merged 5 commits into from
Jun 7, 2024

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented May 6, 2024 •
edited

What does it do?

  • Rework the cli UX and rework prompt
  • Add package manager detection
  • Support pnpm
  • Remove create-strapi-starter

Why is it needed?

  • v5

How to test it?

./node_modules/.bin/create-strapi-app

@alexandrebodin alexandrebodin added source: cli Source is cli package pr: enhancement This PR adds or updates some part of the codebase or features labels May 6, 2024
@alexandrebodin alexandrebodin self-assigned this May 6, 2024
@vercel Vercel
Copy link

vercel bot commented May 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 9:29am

@Marc-Roig
Copy link
Contributor

rework looks good to me! let me know when this is ready to be reviewed and I can QA :)

Also, does it make sense to do some tests on different options to validate it works as intended?

Marc-Roig
Marc-Roig approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Marc-Roig Marc-Roig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did QA with yarn and pnpm, nice ✨

  • Could you document in the generators README this can be tested by using ./node_modules/.bin/create-strapi-app ?

Also, I am going to create a ticket, once creating a new strapi app, I can only see these pages:
image

I need to reload the server to see the rest of pages.

Convly
Convly reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions, but it works well :)

README.md Show resolved Hide resolved
packages/cli/create-strapi-app/src/create-strapi-app.ts Show resolved Hide resolved
packages/cli/create-strapi-app/src/create-strapi-app.ts Show resolved Hide resolved
packages/cli/create-strapi-app/src/create-strapi-app.ts Show resolved Hide resolved
packages/utils/typescript/lib/admin/create-tsconfig-file.js Show resolved Hide resolved
packages/generators/app/src/utils/git.ts Show resolved Hide resolved
packages/generators/app/src/index.ts Show resolved Hide resolved
packages/generators/app/src/utils/usage.ts Show resolved Hide resolved
@alexandrebodin alexandrebodin merged commit 4d3cb65 into v5/main Jun 7, 2024
77 of 84 checks passed
@alexandrebodin alexandrebodin deleted the enh/cli branch June 7, 2024 10:57
@pwizla pwizla mentioned this pull request Jun 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marc-Roig Marc-Roig Marc-Roig approved these changes

@Convly Convly Convly approved these changes

@innerdvations innerdvations Awaiting requested review from innerdvations

Assignees

@alexandrebodin alexandrebodin

Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: cli Source is cli package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexandrebodin @Marc-Roig @Convly