fix(cai): modules must not define providers #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per Terraform [documentation](https://developer.hashicorp.com/terraform/language/modules/develop/providers), provider configurations can be defined only in a root module.
oikarinen
force-pushed
the
tapio-fix-cai-providers
branch
from
c573946
to
c0ac8ba
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
/gcbrun |
eeaton
approved these changes
May 21, 2024
There was a problem hiding this comment.
Thanks for the PR.
This module was originally deployed from a separate repo, we added it in v4 so as to deploy as part of the process for 1-org stage. It seems we missed a few pieces to modify as part of making it smoothly part of this repo.
- convention of not using a provider in a module (fixed by this PR)
- unnecessary steps to specify a service account, should already be configured in the pipeline like other resources (fixed by this PR)
- strange to configure CMEK only for these resources, inconsistent with how CMEK is handled everywhere else. (I'll make a separate issue to track this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Terraform documentation, provider configurations can be defined only in a root module.