-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic endpoints and token to use official Tesla API (self-hosted or from third party provider) #3866
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have been thinking about doing this myself :-) I note you have some I think it is unlikely that people will need a mixture of China vs non-China variables, and this makes it more complicated trying to figure out which variables need to be set. |
I made the same observation. But since we only know a user's region after login, the same settings will work for all users. This is why I did not factor in a single environment variable in a first time. Now, I removed all the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty, lgtm
Not working on my end without any env variables. Will revert as it breaks backwards compatibility
|
same in #3897 |
Sorry I thought I checked it. I fix it ASAP to submit a new PR. |
I introduced dynamic endpoints and a token to maxime compatibility for future Tesla API/streaming change:
token
param to use official Tesla API and Telemetry via by a third party:access_token
andrefresh_token
are refreshed by these third parties that this token parameter is mandatory. Thus TeslaMate does not lose access and the API keys are managed on the third party's site.token
is provided, no inputs are needed when the user sign upA compatible streaming server is also provided by a third party, the stream only sends events with the minimum interval of 1 minute. The streaming interval is the main regression in this operation with official Tesla Telemetry.
However, the new API also contains new data that can make it possible to create interesting new features.