♻️ Refactored code to use encryption algorithm name from settings for consistency #1160
Conversation
sameeramin
force-pushed
the
encryption-algorithm
branch
2 times, most recently
from
324a7d9
to
4dd0555
Compare
sameeramin
changed the title
|
Thank you @menkotoglou, please let me know what else I need to do in order to get this PR merged. |
|
@sameeramin unfortunately I cannot do anything about it, since I'm not a repo maintainer. |
There was a problem hiding this comment.
Thank you for the interest!
I don't think the algorithm should be configurable in the settings, it shouldn't really be variable. Let's better keep it in security.py.
But I agree that the backend utils should use the same variable from security.py. 🤓 Could you please update that?
backend/app/utils.py
Outdated
| @@ -103,14 +103,16 @@ def generate_password_reset_token(email: str) -> str: | |||
| encoded_jwt = jwt.encode( | |||
| {"exp": exp, "nbf": now, "sub": email}, | |||
| settings.SECRET_KEY, | |||
| algorithm="HS256", | |||
| algorithm=settings.ALGORITHM, | |||
There was a problem hiding this comment.
This could be from security.ALGORITHM
backend/app/utils.py
Outdated
| ) | ||
| return encoded_jwt | ||
|
|
||
|
|
||
| def verify_password_reset_token(token: str) -> str | None: | ||
| try: | ||
| decoded_token = jwt.decode(token, settings.SECRET_KEY, algorithms=["HS256"]) | ||
| decoded_token = jwt.decode( | ||
| token, settings.SECRET_KEY, algorithms=[settings.ALGORITHM] |
There was a problem hiding this comment.
This could be from security.ALGORITHM
Sure, I'll update that! |
sameeramin
force-pushed
the
encryption-algorithm
branch
from
4dd0555
to
33d74b2
Compare
No description provided.