Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id3v2: use hyphen minus (U+002D) instead of hyphen (U+2010) #12302

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

vitorhcl
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

The keyboard character is hyphen minus (‐, code point U+002D), while in the page the used character is hyphen (‐, code point U+2010).

This was causing an error with aiofile in my script (#12289).

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Feb 19, 2024
@kbdharun kbdharun added the minor change Change(s) to an existing page(s) which is minor. label Feb 19, 2024
@vitorhcl
Copy link
Member Author

Curiously, tldr-lint didn't catch this wrong character.

@kbdharun
Copy link
Member

Curiously, tldr-lint didn't catch this wrong character.

Can you open an issue for it over there, so that in future we can add a lint rule for this case (I don't think we currently have one for this particular character).

@vitorhcl
Copy link
Member Author

Curiously, tldr-lint didn't catch this wrong character.

Can you open an issue for it over there, so that in future we can add a lint rule for this case (I don't think we currently have one for this particular character).

Done.

@kbdharun kbdharun merged commit 8b2356a into tldr-pages:main Feb 19, 2024
7 checks passed
@vitorhcl vitorhcl deleted the id3v2-fix-hyphen-characters branch February 19, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor change Change(s) to an existing page(s) which is minor. page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants