Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sops: update page #12719

Merged
merged 6 commits into from May 19, 2024
Merged

sops: update page #12719

merged 6 commits into from May 19, 2024

Conversation

Shensen1
Copy link
Contributor

@Shensen1 Shensen1 commented May 3, 2024

Hi,
my first public contribution here, so greetings to my Ma! :)

I think this one is essential, got stuck twice now by remembering this one and so I guess it should be shared with others

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant
Copy link

CLAassistant commented May 3, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the page edit Changes to an existing page(s). label May 3, 2024
@tldr-bot

This comment was marked as resolved.

pages/common/sops.md Outdated Show resolved Hide resolved
pages/common/sops.md Outdated Show resolved Hide resolved
Shensen1 and others added 2 commits May 3, 2024 21:19
Co-authored-by: Magrid <magrid0@proton.me>
Co-authored-by: Magrid <magrid0@proton.me>
@Shensen1
Copy link
Contributor Author

Shensen1 commented May 3, 2024

Ok, nice So now just wait for another ok and then it gets pushed? @Magrid0

But why have the file paths to be in that format? actually wanted to add one simpler syntax example

@Magrid0
Copy link
Member

Magrid0 commented May 3, 2024

Ok, nice So now just wait for another ok and then it gets pushed?

Yep!

But why have the file paths to be in that format? actually wanted to add one simpler syntax example

Because the Style Guide say they have to be written in this way

image

@Shensen1
Copy link
Contributor Author

Shensen1 commented May 3, 2024

Ok, makes sense, head guidelines in mind with

  1. When in doubt, keep new command-line users in mind. Err on the side of clarity rather than terseness. For example, commands that require sudo should include it directly in the examples.

pages/common/sops.md Outdated Show resolved Hide resolved
pages/common/sops.md Outdated Show resolved Hide resolved
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to tldr and thanks for your contribution. LGTM, after @sebastiaanspeck's suggestion above.

@kbdharun kbdharun changed the title added entry about updatekeys sops: add example May 4, 2024
Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i think it'll be ready to merge after sebastiaanspeck suggestion

spageektti and others added 2 commits May 18, 2024 22:46
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@spageektti
Copy link
Collaborator

Since the author of this PR has been inactive for a long time, I have made the suggested changes.

Maintainers Guide says:

If the only issues holding up a merge are trivial fixes
(typos, syntax errors, etc.), and the author doesn't respond in a day or two,
maintainers can make the necessary changes themselves,
and proceed with the merge process.

pages/common/sops.md Outdated Show resolved Hide resolved
pages/common/sops.md Show resolved Hide resolved
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGGM, after the suggestions are fixed

@kbdharun kbdharun changed the title sops: add example sops: update page May 19, 2024
@kbdharun kbdharun merged commit c5a9b7a into tldr-pages:main May 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants