Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bwa: add page #12720

Merged
merged 11 commits into from May 14, 2024
Merged

bwa: add page #12720

merged 11 commits into from May 14, 2024

Conversation

phenolophthaleinum
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • **Version of the command being documented (if known): v0.7.18 **

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label May 3, 2024
@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@phenolophthaleinum
Copy link
Contributor Author

phenolophthaleinum commented May 3, 2024

Tried to fix that lengthy command but whatever I tried it didn't pass the tests. Also, I don't see such a case covered in the style guide. How can I fix it? Shortening the command is not possible, and removing it is really suboptimal.

@fazlearefin
Copy link
Member

fazlearefin commented May 4, 2024

Thanks for your contribution @phenolophthaleinum

This needs review in regards to our style guide. Several commands are being squeezed into a one-liner using ;

Examples are not supposed to be several commands bundled into 1 using ;

@phenolophthaleinum
Copy link
Contributor Author

Thanks for your contribution @phenolophthaleinum

This needs review in regards to our style guide. Several commands are being squeezed into a one-liner using ;

Examples are not supposed to be several commands bundled into 1 using ;

Okay. So that way it will make more sense to make subcommand pages for that.

Removed the complicated commands, since they're not used frequently, and adding subcommand pages will be messy, thus I pass it for now.
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, very detailed!

pages/linux/bwa.md Outdated Show resolved Hide resolved
pages/linux/bwa.md Outdated Show resolved Hide resolved
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to tldr and thanks for your contribution. I have some suggestions for this page.

pages/linux/bwa.md Outdated Show resolved Hide resolved
pages/linux/bwa.md Outdated Show resolved Hide resolved
pages/linux/bwa.md Outdated Show resolved Hide resolved
phenolophthaleinum and others added 4 commits May 10, 2024 09:18
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

pages/linux/bwa.md Outdated Show resolved Hide resolved
pages/linux/bwa.md Outdated Show resolved Hide resolved
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@kbdharun kbdharun merged commit b6ea0b6 into tldr-pages:main May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants