Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages.*: sync page titles #12734

Merged
merged 15 commits into from
May 8, 2024
Merged

pages.*: sync page titles #12734

merged 15 commits into from
May 8, 2024

Conversation

sebastiaanspeck
Copy link
Member

@sebastiaanspeck sebastiaanspeck commented May 5, 2024

This PR is the result of the newly introduced Python-script in #12732

Edit:
As long as #12732 is not merged, this is just for showcasing the output.

@github-actions github-actions bot added documentation Issues/PRs modifying the documentation. tooling Helper tools, scripts and automated processes. translation Translate pages from one language to another. labels May 5, 2024
@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

kant
kant previously requested changes May 5, 2024
Copy link
Member

@kant kant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, some LGTM

pages.es/common/fossil-delete.md Outdated Show resolved Hide resolved
pages.es/common/fossil-forget.md Outdated Show resolved Hide resolved
pages.es/common/fossil-new.md Outdated Show resolved Hide resolved
pages.es/common/gh-cs.md Outdated Show resolved Hide resolved
pages.es/common/pio-init.md Outdated Show resolved Hide resolved
pages.es/common/tlmgr-arch.md Outdated Show resolved Hide resolved
pages.es/common/type.md Outdated Show resolved Hide resolved
pages.es/linux/ip-route-list.md Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just the title, the entire page is misleading. This isn't even a command.

These pages with mismatched titles, it all looks like #11373 again. It's an automatically generated page with set-alias-page.py, which as of now makes a whole lot of mistakes when translating pages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just the title, the entire page is misleading. This isn't even a command.

These pages with mismatched titles, it all looks like #11373 again. It's an automatically generated page with set-alias-page.py, which as of now makes a whole lot of mistakes when translating pages.

Yes, I was improving that script as well. For clamav I know what happened. This page in English is a collection of three tldr-references, but the script can only cope with one tldr-reference. There are many more alias pages with incorrect contents. The script right now only checks "can I find a line that matches the regex ^tldr <command>?" And if so, just create a new page called command.md with the contents of the template as described in https://github.com/tldr-pages/tldr/blob/main/contributing-guides/translation-templates/alias-pages.md. But there are many scenarios for an alias page today, besides an alias page, a page with ^tldr <command> is also used to mention an superseded command, or in the case of clamav, a collection of commands.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pages with mismatched titles, it all looks like #11373 again. It's an automatically generated page with set-alias-page.py, which as of now makes a whole lot of mistakes when translating pages.

This specific page was introduced along way back, so the issue existed for 2 years without anyone noticing.

pages.pl/common/fossil-ci.md Outdated Show resolved Hide resolved
@@ -1,4 +1,4 @@
# fossil-new
# fossil new

> To polecenie jest aliasem `fossil-init`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> To polecenie jest aliasem `fossil-init`.
> To polecenie jest aliasem `fossil init`.

pages.pl/common/gh-cs.md Outdated Show resolved Hide resolved
pages.pl/linux/ip-route-list.md Outdated Show resolved Hide resolved
@acuteenvy
Copy link
Member

acuteenvy commented May 8, 2024

There are changes from #12732 here, can you please git revert that? (f7d3c18)

@sebastiaanspeck
Copy link
Member Author

There are changes from #12732 here, can you please git revert that? (f7d3c18)

As shown in the description. This PR is for showcasing the output of the PR that introduces the script

@github-actions github-actions bot added the page edit Changes to an existing page(s). label May 8, 2024
@tldr-bot

This comment was marked as duplicate.

@tldr-bot
Copy link

tldr-bot commented May 8, 2024

Hello! I've noticed something unusual when checking this PR:

  • The page pages.ar/common/clamav.md is outdated, based on number of commands.
  • The page pages.bs/common/clamav.md is outdated, based on number of commands.
  • The page pages.da/common/clamav.md is outdated, based on number of commands.
  • The page pages.de/common/clamav.md is outdated, based on number of commands.
  • The page pages.fr/common/adb-logcat.md is outdated, based on number of commands.
  • The page pages.fr/common/clamav.md is outdated, based on number of commands.
  • The page pages.fr/common/r.md is outdated, based on number of commands.
  • The page pages.hi/common/clamav.md is outdated, based on number of commands.
  • The page pages.id/common/adb-logcat.md is outdated, based on the command contents itself.
  • The page pages.it/common/clamav.md is outdated, based on number of commands.
  • The page pages.ja/common/clamav.md is outdated, based on number of commands.
  • The page pages.ko/common/clamav.md is outdated, based on number of commands.
  • The page pages.lo/common/clamav.md is outdated, based on number of commands.
  • The page pages.ml/common/clamav.md is outdated, based on number of commands.
  • The page pages.ne/common/clamav.md is outdated, based on number of commands.
  • The page pages.no/common/clamav.md is outdated, based on number of commands.
  • The page pages.pl/common/clamav.md is outdated, based on number of commands.
  • The page pages.pl/common/r.md is outdated, based on number of commands.
  • The page pages.pt_PT/common/clamav.md is outdated, based on number of commands.
  • The page pages.ru/common/clamav.md is outdated, based on number of commands.
  • The page pages.sv/common/clamav.md is outdated, based on number of commands.
  • The page pages.tr/common/clamav.md is outdated, based on number of commands.
  • The page pages.uk/common/clamav.md is outdated, based on number of commands.
  • The page pages.zh/common/adb-logcat.md is outdated, based on the command contents itself.
  • The page pages.zh/common/clamav.md is outdated, based on number of commands.
  • The page pages.zh_TW/common/clamav.md is outdated, based on number of commands.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@sebastiaanspeck sebastiaanspeck merged commit 70cc86c into main May 8, 2024
7 checks passed
@sebastiaanspeck sebastiaanspeck deleted the run-set-page-title branch May 8, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues/PRs modifying the documentation. page edit Changes to an existing page(s). tooling Helper tools, scripts and automated processes. translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet