New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemctl: update page #12748
systemctl: update page #12748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, welcome to the project and thanks for your contribution.
The PR looks pretty good, but I have some reservations regarding the description change.
Also as a sidenote, I think this page could use some cleaning up. The inclusion of commands like In my personal opinion and experience, it would be much better to include an example that shows operating on the user daemon ( |
My experience with
IMO a good solution is to add separate pages for those less used commands and then put in the description that common text that says that some subcommands have their own page, such as examples. Even though some of them don't have their own options and/or subcommands, a separate page can be useful for showing the most usegul example even if only flobal options are used. The example will also benefit both from a nice explanation of the purpose of the subcommand and from a nice description of what the example usage actually does :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the changes look very good to me :)
I have some minor suggestions.
About the issue of the usefulness of the current examples, I agree we can discuss this on another PR/issue.
As a positive sidenote:
I liked the pattern of listing the possible values in the right order when there is enough space for this because it gives for the translators the opportunity of translating the possible values.
This is particularly useful when the reader doesn't know / isn't good at English.
We could maybe use this pattern in other pages too, any more opinions?
fc9effa
to
f64c3e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Welcome to tldr and thanks for your contribution.
71e86aa
to
aaf9b17
Compare
Okay let's merge! |
linux