Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plantuml: add metadata-related commands #12763

Merged
merged 3 commits into from May 10, 2024
Merged

plantuml: add metadata-related commands #12763

merged 3 commits into from May 10, 2024

Conversation

swoh816
Copy link
Contributor

@swoh816 swoh816 commented May 8, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the page edit Changes to an existing page(s). label May 8, 2024
kbdharun
kbdharun reviewed May 9, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

pages/common/plantuml.md Outdated Show resolved Hide resolved
pages/common/plantuml.md Outdated Show resolved Hide resolved
swoh816 and others added 2 commits May 9, 2024 17:01
@swoh816 @kbdharun
Update pages/common/plantuml.md
3896526 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@swoh816 @kbdharun
Update pages/common/plantuml.md
858b382 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
gutjuri
gutjuri approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sebastiaanspeck sebastiaanspeck merged commit 50f5a42 into tldr-pages:main May 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@gutjuri gutjuri gutjuri approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@swoh816 @sebastiaanspeck @gutjuri @kbdharun